Better Ai for CounterPutEffect Targets
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 1.1k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 158
Description
https://github.com/Card-Forge/forge/blob/c10b5706f1bc79a8b9475c22cd73cacd68005e5b/forge-ai/src/main/java/forge/ai/ability/CountersPutAi.java#L452-L458
Imo the Targets are calculated wrong ...
First, it should reset targets.
Then it should call: `getValidCardsToTarget` to get the base line of targets
https://github.com/Card-Forge/forge/blob/c10b5706f1bc79a8b9475c22cd73cacd68005e5b/forge-game/src/main/java/forge/game/card/CardUtil.java#L365
then it should call `ComputerUtil.filterAITgts` that should fix #8665
but only if the filterAI list is empty (or the Param doesn't exist) it should fall back to the base logic of `chooseCursedTarget` and `chooseBoonTarget`
and maybe the logic for "don't sacrifice yourself" in between
Contributor guide
Assessment
This issue has not been assessed yet.