Card-Forge / Card-Forge/forge

Translatable Enums Meta

Open
#8,716 18 comments 0 reactions 1 assignee Claimed by @Hanmac View on GitHub
Game Mechanics GUI keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

This Meta Issue is for keeping Track of Enums that might be translated for the GUI.

The easiest part is to return the translated Name via `toString`
But that also means we can't cast the Enums directly to string anymore in other cases.

* `MagicColor.Color` wasn't used that often yet, and the toString wasn't used
* `ZoneType` it is used in this Join, but might be cleaned up better: https://github.com/Card-Forge/forge/blob/1cb9e78b21fba3674477442a978e4299374a7f98/forge-game/src/main/java/forge/game/card/CardFactoryUtil.java#L3428-L3430
* `CoreType` I want to translate them there, so I can translate the Choices in #8692

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.