Card-Forge / Card-Forge/forge

Cleanup some ProtectEffect Code

Open
#8,692 2 comments 0 reactions 1 assignee Claimed by @Hanmac View on GitHub
Game Mechanics GUI keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

Cleanup Cards that use ProtectEffect and ProtectAllEffect

* `Gains$ Choice | Choices$ AnyColor` the `Gains` Param isn't really needed there, having `Choices` Param should be enough
* replace `Gains$ ChosenColor` with `Choices$ AnyColor` if possible
(5 cards have this, and only `Floating Shield` should really have it)
This might clean up some logic there
* some cards with fixed color words like `Grotesque Hybrid gains flying and protection from green and from white until end of turn.` should probably use Pump effects instead
* the real reason: I want to add a Translatable Record class that uses Object (mostly string/enum?) and Label in their `toString` function, so the GUI choices gets translated for Human. See #8690

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.