Card-Forge / Card-Forge/forge

Property Cleanup Meta

Open
#8,670 2 comments 0 reactions 2 assignees Claimed by @tool4ever View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

Remove of "Not"/"non" Properties in favor of "!" negation

Card:

- [x] NotTriggered
- [x] notnamed
- [ ] notTributed
- [ ] NotDefined
- [ ] notExertedThisTurn
- [x] IsNotRemembered #9797
- [x] notattacking
- [x] notblocking
- [ ] nonChosenCard
- [ ] `sharesNameWith NonToken` ?
- [ ] `doesNotShareNameWith`
- [ ] `greatestCMC_NonLandPermanent` ?

Player:

- [ ] NonActive

CardState:

- [ ] `non` + ColorWord
- [ ] `non` + StringType (SubTypes)
- [ ] ChosenType + `chosenType.startsWith("Non")`
- [ ] IsNotChosenType/IsNotChosenType2

SpellAbility:

- [x] nonManaAbility

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.