Move CantBlock Additional Text from getAbilityText to getNonAbilityText
Open
Game Mechanics
GUI
keep
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 1.1k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 163
Description
Stuff that is added to a Card Description by outside effects should not use getAbilityText, but more like getNonAbilityText or something else
currently, it is added only in getAbilityText, which because it is so complex, isn't updated often
https://github.com/Card-Forge/forge/blob/95e5b7afca5c9fa5ea3049092438535966c77786/forge-game/src/main/java/forge/game/card/Card.java#L2989-L3027
which then causes this ugly refresh:
https://github.com/Card-Forge/forge/blob/95e5b7afca5c9fa5ea3049092438535966c77786/forge-game/src/main/java/forge/game/GameAction.java#L793-L815
it also would help to separate the features with "Non ability features"
Contributor guide
Assessment
This issue has not been assessed yet.