Card-Forge / Card-Forge/forge

Exiling until something leaves the battlefield broken in GameState / Puzzle Mode

Open
#654 4 comments 0 reactions 2 assignees Claimed by @tool4ever View on GitHub
BUG keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

**Describe the bug**
As of the current upstream master, the game uses a new method of storing cards that are exiled until a certain card leaves the battlefield (getExiledUntilThisLeavesBattlefield / setExiledUntilThisLeavesBattlefield), however, this is not stored or restored correctly in the GameState, breaking dev mode dump/load game state for states that use this feature, as well as breaking all the puzzles that use cards which exile things until they leave the battlefield.

**To Reproduce**
Cast Mysterious Limousine and exile something with it, then save the game state and reload it with the dev features. The information about exiling until the card LTBs is lost.

**Expected behavior**
The game should correctly store and restore these cards in the game state, not breaking the Puzzle Mode or dev mode dump/load feature.

Can this somehow be hooked up to the current ExiledWith property in GameState (possibly by detecting the "until this leaves the battlefield" somehow)? If not, then it can be added as its own parameter, e.g. ExiledUntilLTB, but then all the puzzles currently implemented would need to be retroactively looked through and fixed to properly utilize this new parameter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.