Card-Forge / Card-Forge/forge

Can't Untap effects needs to be rewritten

Open
#6,011 6 comments 0 reactions 2 assignees Claimed by @tool4ever View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

Can't Untap effects needs to be rewritten, some could be Statics, some could be SpellAbilityEffects.

Different Cases:

- [x] Keyword `CARDNAME doesn't untap during your untap step.` → Static Ability using "CantUntap(Phase)", don't need for `Continuous` ?
- [ ] Also use it for effects like "doesn't untap during its controller's untap step for as long as EFFECTSOURCE remains on the battlefield."
- [ ] Some Effects target a Player: `Creatures target player controls don't untap during that player's next untap step.`
- [ ] Some Effects target a Player and be affected cards: `Tap all creatures target player controls. Those creatures don't untap during that player's next untap step.` the Tricky part is "**that player**"
- [ ] Drawback of Spells and Activated Effects that say: `doesn't untap during your next untap step` need to remember You as affected player.
- [ ] For Effects, we also need to be careful who is owning it, or if the Effect should continue for other players
- [ ] Hidden Keyword `This card doesn't untap during your next untap step.` → CantUntapTurnEffect using N for counting down on the Card. This is only when it means Controller

Better issue for #984

See also:

- `You may choose not to untap CARDNAME during your untap step.` should be a static?
- Also `untaps during each untap step` which should be affected by some of the stuff above
- `CARDNAME untaps during each other player's untap step`
- `CARDNAME untaps during each opponent's untap step.`

Old Branch that is getting recycled: https://github.com/Card-Forge/forge/tree/untapRework

i probably try to do this in smaller sections

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.