Card-Forge / Card-Forge/forge

Are triggeringObjects sometimes set too late?

Open
#4,844 3 comments 0 reactions 0 assignees View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

I was investigating #2248 for _Welcoming Vampire_ follow-up (since ChangesZoneAll supports some LKI now):

And while it does trigger now, it fails to set the triggeringObjects correctly because its Valid filtering only happens later (after the token has the Equipment buff) - Not a big deal in this case but probably matters somewhere.

Maybe for more accurary the triggeringObjects should also be set when the WaitingTrigger is created? (just like with Controller done in #4484)

Also what I did for _Mentor of the Meek_ in the related PR still has room for improvement with simultaneous zone changes:
currently I still get one trigger if two _Kongming_ ETB together

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.