Card-Forge / Card-Forge/forge

Searching multiple zones

Open
#3,587 0 comments 0 reactions 0 assignees View on GitHub
Card Cleanup keep Rules compliance
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

After refactor of 19cca4ce ChangeZoneAll effect still has a big code chunk related to library searching.

- [x] However only one remaining script actually uses it: _Haunting Echoes_ which could be updated to ChangeZone easily

- [ ] But maybe the previous scripts also need an improvement as they would currently lead to multiple events of zone changes, e. g. _Counterbore_ finding graveyard and library cards should probably still trigger _Laelia_ only once, not twice?

- [x] There are also multiple other cards still carrying a now non-existing Search$ param for clean up

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.