Card-Forge / Card-Forge/forge

Refactor Pump with DefinedKW, maybe Static?

Open
#2,741 2 comments 0 reactions 1 assignee Claimed by @Hanmac View on GitHub
AI Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

currently Pump with DefinedKW is ugly, and might lead to slightly wrong keywords, like Skrelv:

`Hexproof:Card.ChosenColor:chosen` becomes `Hexproof:Card.Red:chosen` which is slightly different from `Hexproof:Card.Red:red` so some logic might not find it, for GUI it gets the wrong icon.

Some tweaks there needs to be done so the generated keyword is better done. (Or should it use Static Effect?)
For this, `Hexproof:Card.ChosenColor:chosenColor` might be better like it is done with StaticAbilities

Some other corner cases needs to be tweaked too:
`Protection from opponent of ActivatorName | DefinedKW$ ActivatorName` with special handling sound wrong imo
let it handle the PlayerUID and PlayerName internal like with StaticAbilities

**For Ai**
ChooseColor -> Pump & DefinedKW (Hexproof) -> Static Effect (CantBlockBy)

* The AI need better logic on how to use such effects, especially to avoid duplicates. (activating it more than once with the same value)
* Also the AI needs to understand that this ChooseColor can result into a Hexproof from color so it can fizzle spells
* In general, AI needs to understand the Static Effect more for when it should do them

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.