Card-Forge / Card-Forge/forge

Attack and Block Restrictions should use Static Abilities

Open
#1,424 1 comment 1 reaction 1 assignee Claimed by @Hanmac View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

* Block Restrictions in PhaseHandler should use Static Ability, the remaining blockers can be used as variable to the checks

* for Attack Restrictions, it also should use a Static and should not use AttackRestrictionType Enum.
Especially `AttackRestrictionType.NEED_BLACK_OR_GREEN` is problematic because of color text changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.