Card-Forge / Card-Forge/forge

Possible better naming for RememberCopies / RememberNewCard params

Open
#1,183 2 comments 1 reaction 0 assignees View on GitHub
keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

> Perhaps "RememberCopy" is a better alternative name for the new param, but this is debatable, I like this variant as well :)

"RememberCopies" is part of Demonstrate, but that might be better renamed "RememberCopied" or "RememberCopySource" as it remembers the SpellAbility that is copied, not the resulting card on the stack

_Originally posted by @Northmoc in https://github.com/Card-Forge/forge/issues/1176#issuecomment-1193065377_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.