Card-Forge / Card-Forge/forge

Mobile UI card selection outline sometimes doesn't clear when it should

Open
#11,802 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

**Describe the bug**
When selecting cards to convoke, they get a purple outline when selected. After the spell is done casting, this outline should clear. But sometimes it does not.

**To Reproduce**
Steps to reproduce the behavior:
1. Have a convoke spell, in my case Sprout Swarm. I also have Witherbloom in play making it only cost {G} with buyback.
2. Cast it, choose to pay for buyback, select a Swarm token to convoke, giving it a purple outline.
3. Repeat step 2, do it fast enough and the bug will trigger fairly reliably.
4. See how some tokens still have the purple outline from being selected for buyback even after the spell has resolved.

**Expected behavior**
The purple outline should clear.

**Screenshots**
Image

Here, two of my tokens made from Sprout Swarm still have the purple outline from having been selected for convoke.

**Desktop (please complete the following information):**
- OS: Linux
- Browser: n/a
- Version: 2.0.15 snapshot 08.25

**Additional context**
Very minor and I think a visual only bug.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with Sprout Swarm and buyback by rapidly repeating the convoke selection steps in the mobile UI. Trace how the purple card-selection outline is cleared after spell resolution; done means selected tokens no longer retain the outline, including across rapid repeated casts.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.