Global or Hidden Replacement Effects
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 1.1k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 158
Description
Some Rules Based Replacement Effects happen without adding them to the Card: (see `hasNoAbilities`)
Based on Type:
https://github.com/Card-Forge/forge/blob/1b60237b4144328ab5350a67c13ca2519d6a63b7/forge-game/src/main/java/forge/game/card/CardState.java#L754-L766
Based on Counters:
https://github.com/Card-Forge/forge/blob/1b60237b4144328ab5350a67c13ca2519d6a63b7/forge-game/src/main/java/forge/game/card/Card.java#L7050-L7091
We need to see if we can move this Replacement Effects to something more "global", or if we can add them like extra `getHiddenReplacementEffects`.
So that they don't affect the `getReplacementEffects` method and possible caching attempts. #11409
A global State might result in corner cases, because Replacement Effects are only run once per event.
Contributor guide
Assessment
This issue has not been assessed yet.