Card-Forge / Card-Forge/forge

Use Predicate for getDamageDoneThisTurn

Open
#11,014 1 comment 0 reactions 1 assignee Assigned to @Hanmac View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

These two should probably be rewritten when getDamageDoneThisTurn supports Predicates for the Source and Target

https://github.com/Card-Forge/forge/blob/debd8931404535ab86d4c9416db5ecdb1ed86902/forge-game/src/main/java/forge/game/player/Player.java#L2156-L2162

These two should probably be reworked into Predicates
https://github.com/Card-Forge/forge/blob/debd8931404535ab86d4c9416db5ecdb1ed86902/forge-game/src/main/java/forge/game/card/CardDamageHistory.java#L262-L268

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.