Card-Forge / Card-Forge/forge

PaperCard duplicates data from CardEdition.EditionEntry

Open
#10,939 5 comments 0 reactions 3 assignees Claimed by @tehdiplomat View on GitHub
CardDB Game Mechanics keep Serialization
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

PaperCard should use CardEdition.EditionEntry that was used while creating the Card.

So when CardDb uses CardEdition to create PaperCard, it should reuse the EditionEntry objects.

So `collectorNumber`, `rarity`, and `artistName` can be removed in PaperCard and be reused from EditionEntry.

(functionalVariant too)

if added, Scryfall_UUID should be added to EditionEntry

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.