Card-Forge / Card-Forge/forge

Handle Land Played This Turn via List for MayPlay uses

Open
#10,465 1 comment 0 reactions 1 assignee Claimed by @Hanmac View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
163

Description

For #4700 part about `incMayPlayTurn`

I want Player::getLandPlayedThisTurn to return a `List` (mostly LandAbility)
maybe stored in Game like `SpellCastThisTurn` (but Lands can only be played by active turn player?)

https://github.com/Card-Forge/forge/blob/226cc45ea857f9054daa72c9ae3d219d362fc5a6/forge-game/src/main/java/forge/game/player/Player.java#L2245-L2255

While checking this code, I found this problem:
https://github.com/Card-Forge/forge/blob/226cc45ea857f9054daa72c9ae3d219d362fc5a6/forge-ai/src/main/java/forge/ai/ability/DestroyAi.java#L418-L419
LandsPlayedLastTurn isn't really correct for multiplayer, because it doesn't look at TargetPlayers last turn.

If I store a copy of the LandAbility, I might implement this in java:
https://github.com/Card-Forge/forge/blob/a81bd0f4a07c8099000b0a28907d1f4709a22c85/forge-gui/res/cardsfolder/v/visions_of_phyrexia.txt#L11-L12
https://github.com/Card-Forge/forge/blob/a81bd0f4a07c8099000b0a28907d1f4709a22c85/forge-gui/res/cardsfolder/s/spider_man_2099.txt#L13-L14

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.