CaptainFact / CaptainFact/captain-fact
Behaviour depending on environments should be configured not hardcoded
Open
- Dominant language
- No language data
- Stars
- 71
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
In several places, the code behaviour rely on which `env` it is running on
Places should be listed down here :
- `apps/captain_fact/lib/captain_fact/accounts/accounts.ex` #fetch_picture (now line 182)
The right solution is to implement test purpose module and to configure it. An example for such thing is the Arc storage : S3 in production, local in dev and test
Contributor guide
Assessment
This issue has not been assessed yet.