Capgemini / Capgemini/Apollo

fix when we use is defined without != '' in ansible roles

Open
#536 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
718
Forks
100
PR merge metrics
No merged PRs in 30d

Description

marathon_artifact_store_dir is defined and marathon_artifact_store_dir != ''
/workspace/apollo/roles/consul/tasks/main.yml:
57: when: consul_join is defined
71: when: consul_join is defined

/workspace/apollo/roles/docker/tasks/main.yml:
37: when: http_proxy is defined and http_proxy != ''

/workspace/apollo/roles/marathon/tasks/main.yml:
11: when: marathon_artifact_store_dir is defined

/workspace/apollo/roles/mesos/defaults/main.yml:
35: {% if mesos_master_quorum is defined %}

/workspace/apollo/roles/serverspec/tasks/main.yml:
48: when: test_role is defined and serverspec_run_tests

/workspace/apollo/roles/zookeeper/defaults/main.yml:
10: {%- if zookeeper_host_list is defined -%}

/workspace/apollo/roles/zookeeper/templates/zoo.cfg.j2:
6: {% if zookeeper_conf is defined %}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.