CakeML / CakeML/cakeml

Check for struct shape removal in Pancake's Return semantics

Open
#1,474 0 comments 0 reactions 0 assignees View on GitHub
low effort Pancake
Dominant language
Standard ML
Stars
1.2k
Forks
104
Avg merge
2d 21h
Merged PRs (30d)
16

Description

Multivalued return is now implemented so the check in Pancake semantics for struct fitting inside the `Temp` stores at wordLang is unnecessary and can be removed from here.
```
(evaluate (Return e,s) =
case (eval s e) of
| SOME value =>
if size_of_sh_with_ctxt s.structs (shape_of value) <= 32
then (SOME (Return value),empty_locals s)
else (SOME Error,s)
| _ => (SOME Error,s)) /\
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating Pancake's Return semantics and the wordLang Temp-store check shown in the issue. Confirm how multivalued returns are handled, remove the struct-shape size check, and verify that the existing Pancake semantics checks still pass without the obsolete condition.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.