makeSplineApprox cannot throw ValueErrors anymore
Open
Beginner friendly
OCCT8
- Dominant language
- Python
- Stars
- 5.8k
- Forks
- 541
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 5
Description
It seems that IsDone()==False cannot be reached. See: https://github.com/Open-Cascade-SAS/OCCT/blob/3d097a0328e71b826377d4814ab05ec3c3d23871/src/ModelingAlgorithms/TKGeomAlgo/GeomAPI/GeomAPI_PointsToBSpline.cxx#L115
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the makeSplineApprox entry point and compare its IsDone() handling with the linked OCCT implementation. Confirm whether the ValueError path is unreachable, then run the existing spline-related tests or checks to verify the resulting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100