CadQuery / CadQuery/cadquery

Workplane.__add__ raises ValueError instead of returning NotImplemented

Open
#1,693 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.8k
Forks
541
Avg merge
3d 2h
Merged PRs (30d)
5

Description

From python docs:

If one of those methods does not support the operation with the supplied arguments, it should return [NotImplemented](https://docs.python.org/3/library/constants.html#NotImplemented).

It currently just calls .union(), which leads to raising a ValueError()

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.