CadQuery / CadQuery/cadquery

`cskHole` generates incorrect results for shallow holes

Open
#1,653 3 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Python
Stars
5.8k
Forks
541
Avg merge
3d 2h
Merged PRs (30d)
5

Description

https://github.com/CadQuery/cadquery/blob/3cd327a2dbaf3bae6791463a3dcb0ad7a714b607/cadquery/cq.py#L2930-L2988

If the cone generated by the angle and diameter is taller than the depth of the hole, it still cuts through and forms a conical cutout where I think it should be truncated.

I'll add more details soon, and am also happy to submit a PR myself unless someone beats me to it!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.