CadQuery / CadQuery/cadquery

eachpoint test issue?

Open
#1,218 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.8k
Forks
541
Avg merge
3d 2h
Merged PRs (30d)
5

Description

I think there's a bug in the eachpoint tester logic.
https://github.com/CadQuery/cadquery/blob/23560289f1b76c25e2f06a0bbc9c17ebfebd5824/tests/test_cadquery.py#L5183-L5201

We make four things in that test:
```
Vector(),
Location(Vector(0, 0, -1,)),
Sketch().rect(1, 1),
Face.makePlane(1, 1),
```

then we use `eachpoint()` to turn those four things into points and make faces located at those points:
```
.eachpoint(lambda l: Face.makePlane(1, 1).locate(l))
```

The second thing (`Location(Vector(0, 0, -1,)), `) should have a `(0, 0, -1)` location and all the others should have `(0, 0, 0)` ones.

So why should we expect a check that checks that the center of all the created faces are in the same place (`(0, 0, 0)`) pass?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.