CadQuery / CadQuery/cadquery

Plane.rotate and Location.toTuple are not compatible

Open
#1,195 0 comments 0 reactions 0 assignees View on GitHub
usability
Dominant language
Python
Stars
5.8k
Forks
541
Avg merge
3d 2h
Merged PRs (30d)
5

Description

When I create a plane and rotate it and look at the resulting location tuple, I see different angles.

```python
In [63]: loc = cq.Plane((0,0,0)).rotated((125, 40, -57)).location

In [64]: [degrees(a) for a in loc.toTuple()[1]]
Out[64]: [120.18645383067272, 29.09092168459621, 61.48113195385812]
```

I know that Euler angles are not unique, but this is a different issue: To me `Plane.rotate` has implemented intrinsic XYZ Euler angles, while `toTuple` retrieves extrinsic XYZ Euler angles:

```python
In [65]: [degrees(a) for a in loc.wrapped.Transformation().GetRotation().GetEulerAngles(gp_EulerSequence.gp_Intrinsic_XYZ)]
Out[65]: [125.00000000000001, 40.000000000000014, -57.00000000000001]
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.