CadQuery / CadQuery/cadquery

`eachpoint(..., useLocalCoordinates=False)` manipulates the point's location when it shouldn't

Open
#1,099 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.8k
Forks
541
Avg merge
3d 2h
Merged PRs (30d)
5

Description

Here's what the docs say `eachpoint()` should do:
https://github.com/CadQuery/cadquery/blob/a5fadebe72b2a46881c3847cca748b8cf716ccd0/cadquery/cq.py#L2440-L2441

When `each()` is called with `useLocalCoordinates=False`, it does no manipulation of the object before passing it on to the callback function:
https://github.com/CadQuery/cadquery/blob/a5fadebe72b2a46881c3847cca748b8cf716ccd0/cadquery/cq.py#L2423

but when `eachpoint()` is called with `useLocalCoordinates=False`, it manipulates/transforms (`p * loc`) the object's location before passing it on to the callback function:
https://github.com/CadQuery/cadquery/blob/a5fadebe72b2a46881c3847cca748b8cf716ccd0/cadquery/cq.py#L2479

I guess it probably shouldn't do that.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.