CadQuery / CadQuery/OCP

OCP seems to generate wrong function signature for array arguments

Open
#156 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
197
Forks
47
Avg merge
2d 2h
Merged PRs (30d)
6

Description

OCP seems to generate wrong function signature for array arguments.

For example, OCCT has:
```c
void HLRAlgo::InitMinMax (const Standard_Real Big, Standard_Real Min[16], Standard_Real Max[16])
```
But OCP lists `OCP.HLRAlgo.HLRAlgo.InitMinMax_s()` as:
```python
TypeError: InitMinMax_s(): incompatible function arguments. The following argument types are supported:
1. (Big: float, Min: float, Max: float) -> None
```

Of course, if you actually try calling it with just `float`, it crashes:
```python
>>> from OCP.HLRAlgo import HLRAlgo
>>> HLRAlgo.InitMinMax_s(0., 0., 0.)
*** stack smashing detected ***: terminated
Aborted
```

I'm not sure if there are any array-argument-taking functions which are likely to be used by anyone (I was only trying to use the MinMax things in HLR to verify I've understood some code correctly, not for actual work); Grepping does indicate that they are used at least in a few other places, but I don't know if those are things that anyone is likely to want to use.

What I'm saying is, I'm not sure if this is "worth" fixing properly (ie. adding support for array arguments), and how hard that would be to do - but if it's decided that it's not worth fixing *properly*, maybe the functions could at least be made to raise an error when called, instead of actually allowing the call with the wrong signature to go through and crash the program?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.