CacheControl / CacheControl/json-rules-engine

OnSuccess/OnFailure properties as part of the rule - Security Issue

Open
#323 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.1k
Forks
507
PR merge metrics
No merged PRs in 30d

Description

There are 2 properties like Onsuccess and Onfailure property which can be a javascript function delegate and it is part of the rule right?

onSuccess: function(event,almanac) { console.log('hello success') },
onFailure : function(event,almanac) { alert('hello failed') }

Is it safe to store this as part of the rule in the database. Because the rule comes from the server to the client this script can be tampered by the hacker and we would end up executing a malicious script. Is that right?

Or Is my understanding wrong? Please confirm

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.