CUAHSI / CUAHSI/HydroServerLite

Adding a new variable name and not selecting a method creates confusing messages

Open
#67 0 comments 0 reactions 0 assignees View on GitHub
CodePlex
Dominant language
PHP
Stars
7
Forks
6
PR merge metrics
No merged PRs in 30d

Description

jirikadlec2[CodePlex]

I go to the page add_variable.php
In the variable name I select Other/New
I enter the new variable name and the new variable definition
I fill in all the other fields, but I don't select any method
I click the quotAdd Variablequot button
A validation error message appears: Please select a method.
When I select a method from the methods drop-down, I get another error message:
quotThe variable name already exists. please select a name from the list.quot
And, when I click OK, I get a message quotVariable successfully added.quot appears. So, Although I get the two error messages, the variable was still probably added to the database, but the two error messages are confusing for the user.

Suggestion:
Don't validate if the user selected the method when adding a new variable. In case the user doesn't select any method in the drop-down, set the method to 'no method specified'.

Why I have this suggestion:
When I'm adding a new variable, I haven't added the new method yet. And, when I'm adding a new method, i must select an existing variable associated with this method. Now it's not possible to add a new method and a new variable at the same time!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the add_variable.php flow described in the issue and reproduce adding a new variable with Other/New selected and no method. Trace the validation and success-message behavior, then verify that omitting a method no longer produces the misleading errors and that the variable is still added with “no method specified”.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.