CUAHSI / CUAHSI/HydroDesktop

Duplicate units

Open
#59 3 comments 0 reactions 0 assignees View on GitHub
CodePlex
Dominant language
C#
Stars
76
Forks
21
PR merge metrics
No merged PRs in 30d

Description

mogikanin[CodePlex]
When HD saving series, it also save units for OffsetType.
HD checks that unit exists in the local database by all unit's fields: UnitsName, UnitsType and UnitsAbbreviation.

But xml with datavalues contains just UnitsAbbreviation and UnitsName:
e.g.

ltoffset offsetTypeID=quot28quotgt
ltoffsetDescriptiongtBelow ground surfacelt/offsetDescriptiongt
ltunits unitsAbbreviation=quotcmquot unitsCode=quot47quotgtcentimeterlt/unitsgt

lt/offsetgt

So, after save series, in Units table there are 2 same units:
UnintsName | UnitsType | UnitsAbbreviation|
centimeter Length cm
centimeter unknown cm

I think, need check that unit exists in the database only by 2 fields: UnintsName and UnitsAbbreviation

P.S. I tested this on quotDry Creek Experimental Watershedquot and keyword quotSoil Moisturequot.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the HD series-saving flow and inspect how the Units table matches units when XML data values provide only UnitsAbbreviation and UnitsName. Reproduce with the Dry Creek Experimental Watershed dataset and “Soil Moisture” keyword; done means saving the series does not create duplicate centimeter rows with different UnitsType values.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.