Decider workflow - Request decision via email :forbidden error
- Dominant language
- Clojure
- Stars
- 66
- Forks
- 28
- Avg merge
- 7d 4h
- Merged PRs (30d)
- 2
Description
When using a decider workflow, as handler, if I attempt to "Request decision - via email", it throws a slightly cryptic :forbidden error. This is possibly by design, since the decider-workflow permissions do not include invite-decider. This is presumably because the decider is more powerful than a reviewer, and forbidding this option is a sensible security decision. But I feel that if it is forbidden, we should not see the option to Request decision via email. And is there a reason why the default workflow includes the invite-decider ability but not the decider workflow?
I can hide that "#invite-decider-action-button" using extra-styles.css, but this probably will hide it for *all* workflow types (not just decider). If I really want to be able to do this, I believe that I could add the permission to the application/model.clj file and rebuild. I would prefer to use that as a last resort, since I don't really want to diverge from the main code trunk.
I'm wondering if maybe a better option would be a configuration parameter that will override the default more secure option of not permitting invitation of deciders and allow it, and thus make visible the option of "via email" in the "Request decision" button.
Or maybe such an option already exists and I haven't found it yet? Apologies for the time wasting if so.
Contributor guide
Research direction
Start by tracing the decider workflow's Request decision via email action and the #invite-decider-action-button, then inspect the permission configuration mentioned in application/model.clj. Compare the decider and default workflow permissions and determine the intended behavior for forbidden invitations. Done means the UI and permission behavior no longer expose an action that predictably returns :forbidden, or the supported configuration is clearly implemented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- authorization, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100