CSCfi / CSCfi/rems

Check the logging parameters

Open
#2,731 0 comments 0 reactions 0 assignees View on GitHub
Good First Issue Hacktoberfest Investigate Technical Debt
Dominant language
Clojure
Stars
66
Forks
28
Avg merge
7d 4h
Merged PRs (30d)
2

Description

While reviewing #2728 we noticed that `log/error` wants to have the `Throwable` as first argument. Let's investigate if we have many places where the argument order is not correct and fix them. This same applies to the other `log/xxx` methods.

See [original note](https://github.com/CSCfi/rems/pull/2728#discussion_r711581707).

- [ ] check the argument order of all logging calls and fix any with the incorrect order
- [ ] (optional) make sure all logging calls start with `log/` if they don't (easy to find with grep then)

Contributor guide

Open the contributing guide

Research direction

Start with the logging-call review described in #2728 and the linked discussion. Search the repository for log/ calls, check Throwable-first ordering across the log methods, and identify calls that do not use the log/ prefix. Done means incorrect orders are fixed and, if taking the optional item, all logging calls use the prefix.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.