CSCfi / CSCfi/rems

Private fields in `get-application-for-user`?

Open
#2,654 0 comments 0 reactions 0 assignees View on GitHub
Technical Debt
Dominant language
Clojure
Stars
66
Forks
28
Avg merge
7d 4h
Merged PRs (30d)
2

Description

In PR #2651 (implementing #2453), it would've been nice to be able to add some fields to `get-application-for-user` that wouldn't get output from the GET /api/application/:id API.

For the not-customized-per-user applications we have two different formats: `get-application-internal` and `get-application`. Perhaps we need to add `get-application-internal-for-user`? Or is it too many different formats?

Another option would be to strip out keys from the application on the API level. However that might make it hard to know what's being hidden and what's not, leading to leaks of internal information.

Contributor guide

Open the contributing guide

Research direction

Start by reading PR #2651 and issue #2453, then compare the get-application-for-user, get-application-internal, and get-application formats mentioned here. Decide whether private per-user fields need a separate format or explicit API filtering, with completion defined by preventing internal information from appearing in GET /api/application/:id.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
api, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.