CSCfi / CSCfi/rems

Improve Workflow API, get rid of the s/Any

Open
#2,337 1 comment 0 reactions 0 assignees View on GitHub
Technical Debt
Dominant language
Clojure
Stars
66
Forks
28
Avg merge
7d 4h
Merged PRs (30d)
2

Description

The `Workflow` schema for the workflow API contains `:workflow` with `s/Any`. This should likely be improved to match the other APIs so that `:handlers` is at top level for example. Also it should perhaps match the
`:application/workflow`. Perhaps the other APIs have similar needs?

```
(s/defschema Workflow
{:id s/Int
:organization OrganizationOverview
:owneruserid UserId
:modifieruserid UserId
:title s/Str
:workflow s/Any
:licenses [License]
:enabled s/Bool
:archived s/Bool})
```

Contributor guide

Open the contributing guide

Research direction

Locate the Workflow schema shown in the issue and compare it with the other APIs, especially :application/workflow. Determine how :handlers and the remaining workflow fields should be represented at the top level; done means the API schema no longer uses s/Any and is consistent with the corresponding APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.