Use BASE_URL and not PUBLIC_IPV4 in docker_driver
- Dominant language
- Python
- Stars
- 8
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Using a config intended for an IP address instead of a FQDN here https://github.com/CSC-IT-Center-for-Science/pebbles/blob/master/pebbles/drivers/provisioning/docker_driver.py#L410 causes certificate mismatch issues.
I believe BASE_URL is the one we should be using. Then we need to check that the url is well-formed though so there are no double slashes.
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect pebbles/drivers/provisioning/docker_driver.py around line 410, comparing the use of PUBLIC_IPV4 with BASE_URL. Verify how BASE_URL is formed and ensure the resulting URL is well-formed without double slashes. Done means the driver uses the FQDN-based configuration and avoids certificate mismatch issues.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- cloud, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100