VSS to SAMM exporter does not handle some duplications in correct way
- Dominant language
- Python
- Stars
- 79
- Forks
- 76
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 5
Description
I found that vss-tools to samm exporter, does not seem to handle all kind of duplicate properties in correct way.
For example, I found below duplication when I was creating the VSS v6.0.0 aspect models and had to manually adjust them so to have a working SAMM model(s) of the VSS 6.0 release.
Found Duplicate definitions for:
1. IdCharacteristic - under:
1.1 Vehicle.Powertrain.TractionBattery.Id
1.2 Vehicle.ControlUnit.ID
2. MapCharacteristic - under:
2.1 Vehicle.Cabin.Infotainment.Navigation.Map
2.2 Vehicle.Powertrain.CombustionEngine.MAP
Currently, these are MANUALLY fixed as follows:
1. IdCharacteristic and related nodes are renamed to
1.1 TractionBatteryIdCharacteristic
1.2 ControlUnitIdCharacteristic
2. MapCharacteristic and related nodes are renamed to:
2.1 NavigationEntityMapCharacteristic
2.2 CombustionEngineMapCharacteristic
**REQUIRED:** we need to make sure that VSS-Tools is handling such cases in correct way by prefixing duplicate property names with their parent name as designed to avoid any property duplications in generated SAMM aspect models.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at the VSS-to-SAMM exporter entry point and reproduce the listed duplicate definitions from the VSS v6.0.0 aspect models. Done means generated SAMM aspect models consistently prefix duplicate property names with their parent names, covering IdCharacteristic and MapCharacteristic cases without manual fixes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100