CITCOM-project / CITCOM-project/CausalTestingFramework

Do we need the `BaseTestCase` class?

Open
#394 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Python
Stars
20
Forks
7
PR merge metrics
No merged PRs in 30d

Description

This is just a data class that is never used outside of the CausalTestCase class. If I remember rightly, it was set up to reduce the number of instance variables of a CausalTestCase to satisfy pylint, but then we further increased the number of instance variables, so pylint is sad again anyway. Personally, I think we should just have CausalTestCase and get rid of the BaseTestCase.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BaseTestCase and CausalTestCase definitions and all references to BaseTestCase. Check the existing tests and pylint configuration before removing or consolidating the class. Done means no unnecessary BaseTestCase remains, references are updated, and the test suite and lint checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.