CGI-FR / CGI-FR/PIMO

[SECURITY] Insecure masks responsibility

Open
#155 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
43
Forks
16
PR merge metrics
No merged PRs in 30d

Description

It's the responsibility of the mask to know if it's secure or not. Each time a new mask is added we have to update this function. Maybe we could append a `isSecure()` function on mask interface. and filter on that attribute.

_Originally posted by @youen in https://github.com/CGI-FR/PIMO/pull/65#discussion_r933174963_

Contributor guide

Open the contributing guide

Research direction

Start by locating the mask interface and the function that currently determines which masks are secure. Trace the existing security checks and the masks that implement the interface. Done means security responsibility is exposed through the mask interface, and adding a new mask no longer requires updating a central filter.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.