CATcher-org / CATcher-org/CATcher

Take advantage of Typescript to use more types instead of String

Open
#976 4 comments 2 reactions 2 assignees Claimed by @IzN432 View on GitHub
aspect-CodeQuality difficulty.Easy good first issue p.Low
Dominant language
TypeScript
Stars
92
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Spotted a few cases where types should be used instead of just string
![image](https://user-images.githubusercontent.com/45702380/180585200-da028f7d-f17c-4647-8e40-24c429bcb68c.png)

![image](https://user-images.githubusercontent.com/45702380/180585251-da83adf3-aaba-4879-aa4a-e57bbece96c7.png)

Severity, type, responseTag, status etc can be converted to a type/enum
![image](https://user-images.githubusercontent.com/45702380/180585280-dcf4b7bc-a20a-449e-bccf-13cf1718f658.png)
![image](https://user-images.githubusercontent.com/45702380/180585296-23cddcda-98c3-4c15-b300-2442e949180f.png)
![image](https://user-images.githubusercontent.com/45702380/180585298-11371aa8-a9ba-403a-9ce3-e8592fa58f6d.png)
![image](https://user-images.githubusercontent.com/45702380/180585315-9a3b81fe-94ea-44c1-9297-1ac180df35b7.png)

I'm sure there's more as well, the list is non-exhaustive

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.