C2SP / C2SP/CCTV

Reproducing ML-KEM accumulated tests

Open
#15 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
107
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Hi,

First of all, thanks for these very useful ressources.
Regarding [ML-KEM accumulated test vectors](https://github.com/C2SP/CCTV/tree/main/ML-KEM#accumulated-pq-crystals-vectors), would it be possible to have the code producing these? Also, do we agree that they concern the finalized FIP-203 standard (and not the ipd draft)?

Indeed, I fail reproducing them. I would gladly put the blame on my implementation, however my results fit the hash for 10,000 iteration provided in [the go reference implementation of Kyber768](https://github.com/FiloSottile/mlkem768/blob/d85de16e203922f9cbf858e06f68e51bf6110c43/mlkem768_test.go#L285C15-L285C79) where I removed the `dk` hash update since it is not considered there. I wonder what I might be missing for reproducing those (also, I reproduce the textual output of the [reference implementation test vector of Kyber768](https://github.com/pq-crystals/kyber/blob/main/ref/test/test_vectors.c), at least for 10,000 iterations).

PS: same issues hold at least for ML-KEM-512 accumulated hashes, but I guess the root cause would be the same.

Thanks in advance,
Regards,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.