BurntSushi / BurntSushi/same-file

File size is not actually checked on Windows

Open
#52 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
124
Forks
26
PR merge metrics
No merged PRs in 30d

Description

I was checking out the source of this library purely out of interest, and while the comments and docs say at a few places that file size is compared on windows to avoid some false positives, this does not actually seem to be the case.

The key used for comparison on Windows is
```rust
struct Key {
volume: u64,
index: u64,
}
```
which does not include the file size, nor could I find any other place where file size is taken into account.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.