BuildOnViction / BuildOnViction/tomoxjs

Not consistent order response

Open
#5 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
8
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Hey Tomochain Team,

I am not sure which repository would be the right place concerning this question. Since I worked on the API implementation based on this repo and https://apidocs.tomochain.com/?javascript--node#tomodex-apis I decided to create the issue here.

1.: I dont find minOrderSize in the current api. If the orderSize is too small then I have no chance to recognize it through any API (`https://apidocs.tomochain.com/?javascript--node#tomodex-apis-pairs` would be right place I guess).

When I fetch again the order (after I created it) with the same order hash it returns null. Basically it returns always null until the order is "opened". I should get always the right order with the right status when I fetch the order, not null... (including the rejected order which is also null)
I saw on your dex that in websocket you give back ORDER_REJECTED order. When I tried to work around with websocket, I didnt get the ORDER_REJECTED response in my websocket. (regardless of my orders subscription). I get the order size related error message and thats it. I dont care too much about websocket right now though. If I can get proper consistent behavior through the rest API its good enough for me.

2.: If I create a market order, the rest API doesnt give me back the calculated price that was used for the market order on the backend. (On your dex you send a price also for the market order which doesnt seem to make sense for me and doesnt match with your documentation either)

Please let me know if you need any additional details / request params / response object. To resolve this issue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.