BugiDev / BugiDev/react-native-calendar-strip

Adding highlightDateNumberContainerStyle props to index and move renderMarking to outside of CalendarDay.js

Open
#287 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
976
Forks
336
PR merge metrics
No merged PRs in 30d

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-calendar-strip@2.2.1` for the project I'm working on.

highlightDateNumberContainerStyle props type for index and I had to move this renderMarking to outside of the CalendarJs

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/react-native-calendar-strip/index.d.ts b/node_modules/react-native-calendar-strip/index.d.ts
index 3a03cc1..932cf2b 100644
--- a/node_modules/react-native-calendar-strip/index.d.ts
+++ b/node_modules/react-native-calendar-strip/index.d.ts
@@ -133,6 +133,7 @@ interface CalendarStripProps {
highlightDateContainerStyle?: StyleProp;
highlightDateNameStyle?: StyleProp;
highlightDateNumberStyle?: StyleProp;
+ highlightDateNumberContainerStyle?: StyleProp;
disabledDateNameStyle?: StyleProp;
disabledDateNumberStyle?: StyleProp;
markedDatesStyle?: StyleProp;
diff --git a/node_modules/react-native-calendar-strip/src/CalendarDay.js b/node_modules/react-native-calendar-strip/src/CalendarDay.js
index a994066..6c02a75 100644
--- a/node_modules/react-native-calendar-strip/src/CalendarDay.js
+++ b/node_modules/react-native-calendar-strip/src/CalendarDay.js
@@ -502,9 +502,9 @@ class CalendarDay extends Component {
>
{date.date()}

- { this.renderMarking() }

)}
+ { this.renderMarking() }


);
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.