Brooooooklyn / Brooooooklyn/Image

oxipng seems to be missing the strip `safe` and `Vec<String>` option

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
416
Forks
13
Avg merge
10d 23h
Merged PRs (30d)
2

Description

- Docs: https://docs.rs/oxipng/5.0.1/oxipng/enum.Headers.html
- Test: https://github.com/shssoichiro/oxipng/blob/7ffbe1fb7865a8e97512e63cef06bebc245059a1/tests/flags.rs#L224-L230

- `safe` would remove all auxiliary data blocks that do not potentially affect the rendering of the image. For example, Text Chunks will be removed.
- `all` would maintain the current behavior and remove all auxiliary data blocks.

https://github.com/Brooooooklyn/Image/blob/e61083611a6e16e07b38eaefee8d2537c93efe2c/packages/binding/src/png.rs#L131-L139

imageoptim uses safe by default.

https://github.com/ImageOptim/ImageOptim/blob/d8d6bc528f0b19253585d824851e320db3261d03/imageoptim/Backend/Workers/OxiPngWorker.m#L31-L33

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked oxipng Headers documentation and the tests/flags.rs example around lines 224-230, then inspect this repository's PNG option binding. The change is done when the safe and all stripping choices, including the Vec option described in the title, are exposed consistently and the relevant flag behavior is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.