BrighterCommand / BrighterCommand/Brighter

[Fix] rename AmpqUri to AmqpUri (typo in property name)

Open
#4,016 0 comments 0 reactions 0 assignees View on GitHub
0 - Backlog Agent Friendly Breaking Change V11
Dominant language
C#
Stars
2.5k
Forks
296
Avg merge
1d 11h
Merged PRs (30d)
21

Description

## Summary

The property `AmpqUri` on `RmqMessagingGatewayConnection` has the letters 'm' and 'p' transposed. The correct acronym is **AMQP** (Advanced Message Queuing Protocol), so the property should be `AmqpUri`.

The typo exists in both `RMQ.Sync` and `RMQ.Async` packages and is used across 88 files (151 occurrences) including source, tests, and samples.

## Affected files

**Source (property definitions):**
- `src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessagingGatewayConnection.cs`
- `src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessagingGatewayConnection.cs`

**Source (usages):**
- `src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessageGateway.cs` (8)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessageConsumer.cs` (14)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessageProducer.cs` (4)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Async/ConnectionPolicyFactory.cs` (7)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageGateway.cs` (7)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageConsumer.cs` (15)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageProducer.cs` (3)
- `src/Paramore.Brighter.MessagingGateway.RMQ.Sync/ConnectionPoolFactory.cs` (8)

**Plus:** ~70 test files and ~6 sample files

## Impact

This is a **breaking change** for consumers who reference `AmpqUri` directly. Consider:
- Renaming with an `[Obsolete]` shim on the old name for one release cycle, or
- Bundling with other V10 breaking changes

## Suggested fix

Rename the property from `AmpqUri` to `AmqpUri` on `RmqMessagingGatewayConnection` in both RMQ.Sync and RMQ.Async packages, and update all references.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.