Boscop / Boscop/web-view

webview_exit crash on win7 mshtml

Open
#165 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2k
Forks
179
PR merge metrics
No merged PRs in 30d

Description

Env: win7 64, toolchain: x86_64-pc-windows-msvc, try example `dialog` and click `Exit` will get crash, but click the close button on title is ok. The below code patch seems work:
```
WEBVIEW_API void webview_exit(webview_t w) {
struct mshtml_webview* wv = (struct mshtml_webview*)w;
/* DestroyWindow(wv->hwnd); */
PostMessage(wv->hwnd, WM_DESTROY, 0, 0);
/* OleUninitialize(); */
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the crash with the `dialog` example on Windows 7 x86_64-pc-windows-msvc, then inspect the `webview_exit` path for the `mshtml_webview` implementation. Compare the suggested `PostMessage(WM_DESTROY)` behavior with `DestroyWindow` and `OleUninitialize`; done means clicking `Exit` no longer crashes while the title-bar close still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.