Bogdanp / Bogdanp/dramatiq

Improve typing of generics

Open
#752 5 comments 1 reaction 0 assignees View on GitHub
typing
Dominant language
Python
Stars
5.3k
Forks
383
Avg merge
9h 41m
Merged PRs (30d)
2

Description

As discussed in [this](https://github.com/Bogdanp/dramatiq/pull/744#discussion_r2251043238) PR discussion we want to add
```diff
diff --git a/mypy.ini b/mypy.ini
index 7c2cbac..a73163a 100644
--- a/mypy.ini
+++ b/mypy.ini
@@ -3,6 +3,7 @@ pretty = True
show_column_numbers = True
show_error_codes = True
show_error_context = True
+disallow_any_generics = True

[mypy-gevent]
ignore_missing_imports = True
```
and fix the fallout of
```
Found 23 errors in 9 files (checked 89 source files)
```

Contributor guide

Open the contributing guide

Research direction

Start with mypy.ini and enable disallow_any_generics, then run mypy across the 89 source files. Use the reported 23 errors in 9 files to locate the affected annotations and dependencies; the work is done when mypy completes without those errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.