BlueQuartzSoftware / BlueQuartzSoftware/simplnx

ENH: Add Sample and Crystal Reference Frame corrections in the various Ebsd Readers

Open
#1,675 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
17
Forks
13
Avg merge
3d 4h
Merged PRs (30d)
10

Description

When reading Oxford Instruments .ctf | .h5oina files or EDAX/TSL .ang | .h5oim files, the user needs to perform possibly 2 reference frame corrections. These are encapsulated in 2 filters, Rotate Sample Reference Frame and Rotate Euler Reference Frame. This feature request is about integrating those transforms into the actual reader filters themselves by way of a drop down "Choices" parameter where we can have various "standard" transforms that are known to be used by the vendors. The first choice is "No Transform". The second choice is what ever the accepted standard transform is for that vendor.

For TSL this is a 180 degree about the <010> axis for the sample reference frame and 90 degrees about the <001> axis for the Euler reference frame.

For Oxford systems data there is no sample reference frame correction. There is typically a 90 degree about the <001> direction for Euler reference frame.

We would possible make this a pair of checkboxes that are by default checked, which would then show the proper parameter to put in the Axis-Angle rotation (FloatVec4 Parameter I think). If a checkbox is checked then the transform axis-angle is shown and used. That might be a better solution.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.