BlueQuartzSoftware / BlueQuartzSoftware/SIMPL

DataArrayProxy converting dimensions from double to size_t from JSON

Open
#414 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
8
Forks
22
PR merge metrics
No merged PRs in 30d

Description

In `DataArrayProxy::readVector`, an array of numbers is read from JSON and converted to a `std::vector`. This function is used to read the tuple and component dimensions from JSON. This function does some checks on the range of acceptable values; however, it does not report any errors and has an implicit conversion between `double` and `size_t` inside its check. For exceedingly large datasets this would be an issue when attempting to read and write their dimensions.

A possible solution would be to store the dimensions as a string though this would affect backwards compatibility in pipeline files. Additionally better error reporting should be implemented to tell the user why the read failed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.