BlueQuartzSoftware / BlueQuartzSoftware/DREAM3D

Remove default value parameter from filter parameters

Open
#588 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
189
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Some filter parameters do not need a default value passed into them, because they just use the value that is contained in the filter parameter's connected property.

Filter parameters that require the conversion of a numerical value should be the only filter parameters that can potentially use a default value. They either need to use the current default value when that conversion fails, or throw an error if the conversion fails.

So we need to decide if we want to have each filter parameter subclass that needs a default value implement its own, or if we just don't use default values and throw errors instead in those filter parameters.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.